alamb commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147929875
##########
datafusion-examples/Cargo.toml:
##########
@@ -36,7 +36,7 @@ required-features = ["datafusion/avro"]
[dev-dependencies]
arrow = { workspace = true }
-arrow-flight = { version = "34.0.0", features = ["flight-sql-experimental"] }
+arrow-flight = { workspace = true }
Review Comment:
👍
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features =
["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features =
["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
So this means we lose coverage of the non default feature path (which is why
the tests need to be updated?)
##########
datafusion/core/tests/sql/set_variable.rs:
##########
@@ -440,7 +443,10 @@ async fn set_time_zone_bad_time_zone_format() {
.unwrap();
let err = pretty_format_batches(&result).err().unwrap().to_string();
- assert_eq!(err, "Parser error: Invalid timezone \"08\": only offset based
timezones supported without chrono-tz feature");
+ assert_eq!(
+ err,
+ "Parser error: Invalid timezone \"08\": '08' is not a valid timezone"
+ );
// we dont support named time zone yet
Review Comment:
comment looks out of date now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
