tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147932414
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features =
["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features =
["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
The tests need to be updated because
https://github.com/apache/arrow-datafusion/pull/5603 enabled chrono-tz, but
because it was linking in arrow-array 35, this didn't percolate to other crates
that are still using arrow-array 34.
This doesn't change the behaviour of default-features for parquet, this has
been "broken" since the move to workspace dependencies
See
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
