tustvold commented on code in PR #3943:
URL: https://github.com/apache/arrow-rs/pull/3943#discussion_r1148449023
##########
arrow-buffer/src/bigint.rs:
##########
@@ -303,13 +305,14 @@ impl i256 {
let hl = (l_abs.high as u128).checked_mul(r_abs.low)?;
let lh = l_abs.low.checked_mul(r_abs.high as u128)?;
- let high: i128 =
high.checked_add(hl)?.checked_add(lh)?.try_into().ok()?;
Review Comment:
If `high == -i128::MIN` this would fail, as it is performed before reversing
the absolute value conversion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
