tustvold commented on code in PR #3943:
URL: https://github.com/apache/arrow-rs/pull/3943#discussion_r1148449525
##########
arrow-buffer/src/bigint.rs:
##########
@@ -398,6 +404,12 @@ impl i256 {
// needless overflow.
acc.wrapping_mul(base)
}
+
+ /// Returns `true` if this [`i256`] is negative
+ #[inline]
+ pub fn is_negative(self) -> bool {
Review Comment:
This matches the standard method -
https://doc.rust-lang.org/std/primitive.i32.html#method.is_negative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
