mslapek commented on code in PR #5734:
URL: https://github.com/apache/arrow-datafusion/pull/5734#discussion_r1148491935
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -68,7 +69,26 @@ impl ExprSchemable for Expr {
Expr::OuterReferenceColumn(ty, _) => Ok(ty.clone()),
Expr::ScalarVariable(ty, _) => Ok(ty.clone()),
Expr::Literal(l) => Ok(l.get_datatype()),
- Expr::Case(case) => case.when_then_expr[0].1.get_type(schema),
+ Expr::Case(case) => {
+ // when #5681 will be fixed, this code can be reverted to:
Review Comment:
I agree that it's a duck-taping.
I'm afraid the mentioned issue **won't be resolved quickly** by
cut'n'paste... (see
https://github.com/apache/arrow-datafusion/issues/5681#issuecomment-1483780310 )
So the question is - **should we expose our users to the bug** 🧐 until #5681
is fixed? (putting Datafusion's **reputation** at risk?)
What is more, this PR features **sqlogictest** ⭐️, so we won't have a
regression caused by the fix #5681.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
