mslapek commented on code in PR #5734: URL: https://github.com/apache/arrow-datafusion/pull/5734#discussion_r1153534838
########## datafusion/core/tests/sqllogictests/test_files/pg_compat/pg_compat_null.slt: ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +onlyif postgres +statement ok +CREATE TABLE aggregate_test_100_by_sql +( + c1 character varying NOT NULL, + c2 smallint NOT NULL, + c3 smallint NOT NULL, + c4 smallint, + c5 integer, + c6 bigint NOT NULL, + c7 smallint NOT NULL, + c8 integer NOT NULL, + c9 bigint NOT NULL, + c10 character varying NOT NULL, + c11 real NOT NULL, + c12 double precision NOT NULL, + c13 character varying NOT NULL +); + + +# Copy the data +onlyif postgres +statement ok +COPY aggregate_test_100_by_sql + FROM '../../testing/data/csv/aggregate_test_100.csv' + DELIMITER ',' + CSV HEADER; + + +### +## Setup test for datafusion +### +onlyif DataFusion +statement ok +CREATE EXTERNAL TABLE aggregate_test_100_by_sql ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + + +statement ok +CREATE TABLE aggregate_test_100_nullable_by_sql AS +SELECT + *, + CASE + WHEN c4 % 3 = 0 THEN NULL + ELSE c5 + END AS n5, + CASE + WHEN c3 % 3 != 0 THEN c9 + ELSE NULL + END AS n9 +FROM aggregate_test_100_by_sql + + +query III Review Comment: The test involves CASE statement, and it was crashing before the fix (the CREATE TABLE one). The file itself might be useful for other null-related bugfixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
