jorgecarleitao commented on a change in pull request #8401: URL: https://github.com/apache/arrow/pull/8401#discussion_r530077274
########## File path: rust/arrow/src/array/ffi.rs ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Contains functionality to load an ArrayData from the C Data Interface + +use std::convert::TryFrom; + +use crate::{ + error::{ArrowError, Result}, + ffi, +}; + +use super::ArrayData; + +impl TryFrom<ffi::ArrowArray> for ArrayData { + type Error = ArrowError; + + fn try_from(value: ffi::ArrowArray) -> Result<Self> { + let data_type = value.data_type()?; + let len = value.len(); + let offset = value.offset(); + let null_count = value.null_count(); + let buffers = value.buffers()?; + let null_bit_buffer = value.null_bit_buffer(); + + // todo: no child data yet... + Ok(ArrayData::new( + data_type, + len, + Some(null_count), + null_bit_buffer, + offset, + buffers, + vec![], + )) + } +} + +impl TryFrom<ArrayData> for ffi::ArrowArray { + type Error = ArrowError; + + fn try_from(value: ArrayData) -> Result<Self> { + let len = value.len(); + let offset = value.offset() as usize; + let null_count = value.null_count(); + let buffers = value.buffers().to_vec(); + let null_buffer = value.null_buffer().cloned(); + + // todo: no child data yet... Review comment: I added a comment explaining why this is fine (the check is already there) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
