jhorstmann commented on a change in pull request #8401: URL: https://github.com/apache/arrow/pull/8401#discussion_r530311500
########## File path: rust/arrow/src/bytes.rs ########## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains an implementation of a contiguous immutable memory region that knows +//! how to de-allocate itself, [`Bytes`]. +//! Note that this is a low-level functionality of this crate. + +use core::slice; +use std::sync::Arc; +use std::{fmt::Debug, fmt::Formatter}; + +use crate::{ffi, memory}; + +/// Mode of deallocating memory regions +pub enum Deallocation { + /// Native deallocation, using Rust deallocator with Arrow-specific memory aligment + Native(usize), Review comment: I wonder whether it's worth optimizing the size of the `Bytes` struct. If we use [`NonZeroUsize`][1] here, the enum itself might become only be the size of one `usize`, but I haven't tried whether that really works. [1]: https://doc.rust-lang.org/std/num/struct.NonZeroUsize.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
