icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1149425349
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -138,6 +138,77 @@ std::string EnumToString(int value, const
google::protobuf::EnumDescriptor* desc
return value_desc->name();
}
+Result<compute::Expression> FromProto(const
substrait::Expression::ReferenceSegment* ref,
+ const ExtensionSet& ext_set,
+ const ConversionOptions&
conversion_options,
+ std::optional<compute::Expression>
in_expr) {
+ auto in_ref = ref;
+ auto& out = in_expr;
Review Comment:
This is strange - why are we talking `in_expr` as out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
