icexelloss commented on code in PR #34627: URL: https://github.com/apache/arrow/pull/34627#discussion_r1149431797
########## cpp/src/arrow/engine/substrait/expression_internal.cc: ########## @@ -138,6 +138,77 @@ std::string EnumToString(int value, const google::protobuf::EnumDescriptor* desc return value_desc->name(); } +Result<compute::Expression> FromProto(const substrait::Expression::ReferenceSegment* ref, Review Comment: It this method just a refactor of existing code? Are there change/diff from the original code here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
