AlenkaF commented on PR #34658: URL: https://github.com/apache/arrow/pull/34658#issuecomment-1486505102
> This seems to work? Yes, it is working for sequences with `pa.Scalars`. > It won't work for generators of pyarrow scalars (because they will already be consumed the first time we call `_sequence_to_array`. Oh yes, that is true (missed it). > I am not sure we have to worry about that case (since this PR just adding some extra convenience anyway). But we should maybe at least test those cases to ensure it errors (and eg not silently return an empty array) Agree, will add a test 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
