jiangzhx commented on PR #5686:
URL:
https://github.com/apache/arrow-datafusion/pull/5686#issuecomment-1486495590
> I am sorry for the delay in review. I will try and find more time to
review this carefully tomorrow but initially I am surprised that says it
removes duplicated logic adds more code than it removes 🤔
A large number of test cases are based on SQL,
like window,union scenarios are not covered dataframe api.
also the first version of count_wildcard_rule did not cover it.
When I remove the duplicate logic between the DataFrame API and SQL
planning, all the problems are exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
