vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530328033
##########
File path: rust/arrow/src/compute/kernels/aggregate.rs
##########
@@ -180,9 +194,12 @@ where
///
/// Returns `None` if the array is empty or only contains null values.
#[cfg(all(any(target_arch = "x86", target_arch = "x86_64"), feature = "simd"))]
-pub fn sum<T: ArrowNumericType>(array: &PrimitiveArray<T>) -> Option<T::Native>
+pub fn sum<T>(array: &PrimitiveArray<T>) -> Option<T::Native>
where
- T::Native: Add<Output = T::Native>,
+ T: ArrowNumericType,
+ // T::Native: Add<Output = T::Native> + Sum + Sum<T::Simd>,
Review comment:
Yeah, eagle eyes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
