wgtmac commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1142836269
########## cpp/src/arrow/dataset/file_parquet.h: ########## @@ -31,6 +31,8 @@ #include "arrow/dataset/type_fwd.h" #include "arrow/dataset/visibility.h" #include "arrow/io/caching.h" +#include "parquet/encryption/dataset_encryption_config.h" Review Comment: Should we add macros to these header files so the compiler won't complain when encryption is not enabled (e.g. `PARQUET_REQUIRE_ENCRYPTION` is OFF)? Or at least make sure they compile without encryption enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
