wgtmac commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1151394846
########## cpp/src/parquet/encryption/dataset_encryption_config.h: ########## @@ -0,0 +1,31 @@ +#pragma once + +#include "parquet/encryption/crypto_factory.h" +#include "parquet/encryption/encryption.h" +#include "parquet/encryption/kms_client.h" +#include "arrow/dataset/type_fwd.h" Review Comment: Why include `"arrow/dataset/type_fwd.h"`? Seems not used any where. ########## cpp/src/arrow/dataset/file_parquet.h: ########## @@ -31,6 +31,8 @@ #include "arrow/dataset/type_fwd.h" #include "arrow/dataset/visibility.h" #include "arrow/io/caching.h" +#include "parquet/encryption/dataset_encryption_config.h" +#include "parquet/encryption/dataset_encryption_config.h" Review Comment: redundant line ########## cpp/src/parquet/encryption/dataset_encryption_config.h: ########## @@ -0,0 +1,31 @@ +#pragma once + +#include "parquet/encryption/crypto_factory.h" +#include "parquet/encryption/encryption.h" +#include "parquet/encryption/kms_client.h" +#include "arrow/dataset/type_fwd.h" Review Comment: In addition, should we move `parquet/encryption/dataset_encryption_config.h` to `arrow/dataset/parquet_encryption_config.h`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
