rok commented on PR #8510: URL: https://github.com/apache/arrow/pull/8510#issuecomment-1489590186
> @rok given that a large part of my comments are still about the From/ToTensor conversions, I might suggest splitting that off for a follow-up PR, and first get the basic extension type merged (that should for example be sufficient to start with python bindings? To ensure we can get that in time for 12.0) Thanks a lot for the review @jorisvandenbossche! Much appreciated. Splitting out `From/ToTensor` would bring some overhead I'd prefer to avoid if possible and `stride/permutation` is probably the bigger issue. How about we try to finish this PR this week? Python work could be done on a fork meanwhile, I don't think API will change much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
