rok commented on PR #8510: URL: https://github.com/apache/arrow/pull/8510#issuecomment-1490121601
> > `FixedShapeTensorType::shape()` now permutes `shape_` before returning. > > Sorry, I personally feel quite strongly that this basic attribute should always give you the physical shape, which _is_ the shape of type according to the spec (and what is serialized in the metadata), as I mentioned above [#8510 (comment)](https://github.com/apache/arrow/pull/8510#issuecomment-1474104116) Ugh, sorry I've forgot about that and read another comment somewhere as shape should be permuted. I'll revert this. > > Splitting out From/ToTensor would bring some overhead I'd prefer to avoid if possible and stride/permutation is probably the bigger issue > > I would be happy to do it and push a change here (I would also leave the stride computation for the other PR, since that is not needed for implementing the core spec, and so avoids delay on further discussing this aspect) Ok, let me do it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
