HaochengLIU commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1152687683
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2230,6 +2230,15 @@ if(ARROW_TESTING)
1.10.0
USE_CONFIG
${GTEST_USE_CONFIG})
+ get_target_property(gtest_cxx_standard GTest::gtest
INTERFACE_COMPILE_FEATURES)
+
+ if(APPLE
+ AND (${gtest_cxx_standard} STREQUAL "cxx_std_14")
Review Comment:
GoogleTest just bumped its CMake standard [less then a year
ago](https://github.com/google/googletest/blame/main/docs/quickstart-cmake.md)
thus we should be fine here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]