HaochengLIU commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1153207769
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
set(ARROW_SIMD_LEVEL "NEON")
endif()
+ if(APPLE)
+ set(GTest_SOURCE "BUNDLED")
+ endif()
Review Comment:
Also there is no need to do both try_compile and FindXXXAlt.cmake right? The
latter one sounds like an over-engineering solution to me….. Adding a bespoke
findxxxalt.cmake will bloat the cmake code in Arrow with limited benefits. The
upstream findGtest.cmake from CMake and pkgconfig cmake from official GTest
should be the only source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
