kou commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1153909244
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
set(ARROW_SIMD_LEVEL "NEON")
endif()
+ if(APPLE)
+ set(GTest_SOURCE "BUNDLED")
+ endif()
Review Comment:
FYI: If we use the latter approach, we can implement an automatically
fallback solution instead of raising an error for C++ standard miss match. (If
system GoogleTest isn't suitable, we can use our bundled GoogleTest instead of
stopping `cmake`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
