HaochengLIU commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1153243466
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
set(ARROW_SIMD_LEVEL "NEON")
endif()
+ if(APPLE)
+ set(GTest_SOURCE "BUNDLED")
+ endif()
Review Comment:
> - **I think that checking INTERFACE_COMPILE_FEATURES isn't so portable.
For example, libgtest-dev on Debian/Ubuntu still uses cxx_std_11 not
cxx_std_14.**
I agree. As [Arow's minimum CXX_STANDARD requirement is
17](https://github.com/apache/arrow/blob/main/cpp/cmake_modules/SetupCxxFlags.cmake#L128-L130),
how about this:
In this PR, We limit the scope to error out whenever
`INTERFACE_COMPILE_FEATURES` from GTest is lower than 17. It will be universal
to all platforms and truly detect the issue at CMake configure time.
Then in another PR/issue, we can discuss how to implement try_compile and
FindXXXAlt.cmake as it will need nontrivial work.
Ty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
