lidavidm commented on code in PR #570:
URL: https://github.com/apache/arrow-adbc/pull/570#discussion_r1154985653
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -57,6 +57,11 @@ void GetWinError(std::string* buffer) {
#endif // defined(_WIN32)
+// Struct initializers
+static void AdbcErrorInit(struct AdbcError* error) {
+ std::memset(error, 0, sizeof(*error));
Review Comment:
The struggle is that we don't want to assume libc malloc/free (possibly we
could/should have). You can see this pattern in the Arrow C Data Interface as
well where all structs have an explicit release callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
