cdaudt commented on PR #570:
URL: https://github.com/apache/arrow-adbc/pull/570#issuecomment-1492715036
>
> If it's documented in the header (thanks Kou for checking!) then we should
stick to the existing behavior.
this patch doesn't require a change to the existing behaviour. If a caller
does pass in a zero AdbcError then this patch doesn't harm that (just an added
memset overhead which is a small price to pay for the protection to the API
imo).
Do you mean you prefer I drop the patch?
The separate issue of driver-manager -> driver calls bypassing the zero'ed
out AdbcError expectation on purpose seems like a bad way to get driver-manager
& driver to collaborate on filling up an error structure. I can send a separate
patch to try to address that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
