omrimallis commented on PR #34511: URL: https://github.com/apache/arrow/pull/34511#issuecomment-1493356902
@mapleFU To my understanding, Parquet writers still have to encode `ConvertedType` for each field according to the Parquet spec. So when you create a `PrimitiveNode`, its `ConvertedType` is automatically inferred and set from its `LogicalType` (see the constructor of `PrimitiveNode`). The stream writer can therefore always rely on it being present, except in the special circumstances which this PR solves. We can update the code of `StreamWriter` to check against logical types instead, though I see no special benefit for it currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
