indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1156266418
##########
format/FlightSql.proto:
##########
@@ -1842,6 +1842,94 @@ message ActionCancelQueryResult {
CancelResult result = 1;
}
+/*
+ * Request message for the "Close Session" action.
+ */
+message ActionCloseSessionRequest {
Review Comment:
Correct, and to address (will comment "see above") this and other comments
the intention is that the Session-Id will come back via Set-Cookie which will
allow support for session persistence by simply reusing standard cookie
middleware/no additional code. Obviously the client can if it wishes do
something fancier to share them, and the server must implement either (one of)
SetSessionOptions or Resource-Path request header handling in order to support
this feature.
Clients will require try-SetSessionOptions-and-fallback-to-headers logic for
full support. I looked at rolling this into the FlightSqlClient constructor,
and while it was feasible to make that non-breaking the snag was that
introducing by-default middleware injection could easily break a client app's
existing middleware scheme unless we at least introduced some (unreliable, so
no) detection logic to see if any ClientCookieMiddlewareFactory was already
provided by the app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
