indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1156336785
##########
cpp/src/arrow/flight/sql/server.cc:
##########
@@ -423,6 +494,91 @@ arrow::Result<Result>
PackActionResult(ActionCreatePreparedStatementResult resul
return PackActionResult(pb_result);
}
+arrow::Result<Result> PackActionResult(ActionSetSessionOptionsResult result) {
+ pb::sql::ActionSetSessionOptionsResult pb_result;
+ for (SetSessionOptionResult& res : result.results) {
+ switch (res) {
+ case SetSessionOptionResult::kUnspecified:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_UNSPECIFIED);
+ break;
+ case SetSessionOptionResult::kOk:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_OK);
+ break;
+ case SetSessionOptionResult::kInvalidResult:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_INVALID_VALUE);
+ break;
+ case SetSessionOptionResult::kError:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_ERROR);
+ break;
+ }
+ }
+ return PackActionResult(pb_result);
+}
+
+arrow::Result<Result> PackActionResult(ActionGetSessionOptionsResult result) {
+ pb::sql::ActionGetSessionOptionsResult pb_result;
+ for (const SessionOption& in_opt : result.session_options) {
+ pb::sql::SessionOption& opt = *pb_result.add_session_options();
Review Comment:
* This does need to be mutable—do you have a preference for alternative code
pattern to build nested Proto messages like this?
* I would definitely like shared code, however I felt the best path would be
to overhaul all of the Proto<->native object code and factor all of the similar
switch-too-much gunk out of the packing/unpacking code and make all of that
code more readable with a wholesale shift to factored-out conversion code.
Right now there isn't a common location outside of types.h and overriding Proto
constructors from there is kind of ugly factoring as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
