paleolimbot commented on PR #34825:
URL: https://github.com/apache/arrow/pull/34825#issuecomment-1494795731

   > We can't just swap it for as_tibble() inside these functions as we don't 
have the tibble package as a dependency.
   
   I think we can safely add tibble to Suggests and use `as_tibble()` in tests 
that already expect a tibble? Unless I'm misunderstanding the failures?
   
   I think we should definitely make this change! Type stability is important 
and I myself have written `as.data.frame(as.data.frame())` too many times for 
this to be a fluke.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to