alamb commented on code in PR #5863:
URL: https://github.com/apache/arrow-datafusion/pull/5863#discussion_r1157266692
##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -128,7 +126,7 @@ impl ExecutionPlan for SortPreservingMergeExec {
}
fn required_input_ordering(&self) ->
Vec<Option<Vec<PhysicalSortRequirement>>> {
- vec![Some(make_sort_requirements_from_exprs(&self.expr))]
+ vec![Some(PhysicalSortRequirement::exact_from_exprs(&self.expr))]
Review Comment:
I am imagining that when a user upgrades DataFusion they will and see that
the type signature changed from `PhysicalSortExpr` to
`PhysicalSortRequirement`. Then when they look at `PhysicalSortRequirement`
they can find a function to convert the existing `PhysicalSortExpr` to
`PhysicalSortRequirement` -- `PhysicalSortRequirement::exact_from_exprs`
`make_sort_requirements_from_exprs` was both not documented as well as lost
in the list of functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
