alamb commented on code in PR #5863:
URL: https://github.com/apache/arrow-datafusion/pull/5863#discussion_r1157261926
##########
datafusion/physical-expr/src/utils.rs:
##########
@@ -318,27 +314,7 @@ pub fn ordering_satisfy_requirement_concrete<F: FnOnce()
-> EquivalencePropertie
pub fn make_sort_exprs_from_requirements(
required: &[PhysicalSortRequirement],
) -> Vec<PhysicalSortExpr> {
- required
- .iter()
- .map(|requirement| {
- if let Some(options) = requirement.options {
- PhysicalSortExpr {
- expr: requirement.expr.clone(),
- options,
- }
- } else {
- PhysicalSortExpr {
Review Comment:
moved into PhysicalSortExpr::into_sort_expr() where I think it is easier to
find and understand (I needed a version of this in IOx)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
