wgtmac opened a new pull request, #34889:
URL: https://github.com/apache/arrow/pull/34889

   ### Rationale for this change
   
   Parquet specs support storing key-value metadata provided by the user. 
However, the parquet-cpp writer can only set it via ParquetFileWriter::Open(). 
Sometimes user may want to add extra information to it while writing. So it is 
good to support adding extra key-value metadata any time before closing the 
file writer.
   
   ### What changes are included in this PR?
   
   Add a new interface `void AddKeyValueMetadata(std::shared_ptr<const 
KeyValueMetadata> key_value_metadata)` to the `ParquetFileWriter` class. User 
can now add more key-value metadata to the file if not closed.
   
   ### Are these changes tested?
   
   Added a new `Metadata.TestAddKeyValueMetadata` test to verify key-value 
metadata added before closing the writer are well preserved.
   
   ### Are there any user-facing changes?
   
   Yes, user can add custom key-value metadata whenever writer is not closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to