wgtmac commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161375853
##########
cpp/src/parquet/file_writer.h:
##########
@@ -209,6 +212,12 @@ class PARQUET_EXPORT ParquetFileWriter {
/// until the next call to AppendRowGroup or AppendBufferedRowGroup or Close.
RowGroupWriter* AppendBufferedRowGroup();
+ /// \brief Add key-value metadata to the file.
+ /// \param[in] key_value_metadata the metadata to add.
+ /// \note This will overwrite any existing metadata with the same key.
+ /// It will not take effect if Close() has been called.
Review Comment:
Good point! Fixed
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -356,6 +355,15 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return
AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ std::shared_ptr<const KeyValueMetadata> key_value_metadata) override {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
