zeroshade commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1157649134
##########
go/arrow/table.go:
##########
@@ -96,9 +96,9 @@ func NewColumn(field Field, chunks *Chunked) *Column {
}
col.data.Retain()
- if !TypeEqual(col.data.DataType(), col.field.Type) {
+ if !StorageTypeEqual(col.data.DataType(), col.field.Type) {
Review Comment:
this change doesn't make any sense to me. `TypeEqual` should already end up
checking that the storage types are equal by virtue of the extension type
itself implementing the equals check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
