zeroshade commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1157670973
##########
go/parquet/pqarrow/path_builder.go:
##########
@@ -440,7 +440,9 @@ func (p *pathBuilder) Visit(arr arrow.Array) error {
}
return nil
case arrow.EXTENSION:
- return xerrors.New("extension types not implemented yet")
+ // TODO: (hermanschaaf) handle nested extension types
Review Comment:
it should be feasible to just do `return
p.Visit(arr.(arrow.ExtensionArray).Storage())` and that would handle nested
extension types for you just fine. On that note, please add a test with a
nested extension type for precisely this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
