emkornfield commented on code in PR #34054:
URL: https://github.com/apache/arrow/pull/34054#discussion_r1157977282
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -335,6 +340,10 @@ class SerializedPageWriter : public PageWriter {
if (meta_encryptor_ != nullptr) {
UpdateEncryption(encryption::kColumnMetaData);
}
+
+ // Serialized page writer does not need to adjust page offsets.
+ FinishPageIndex(/*final_position=*/0);
Review Comment:
Maybe, FinishPageIndexes (it took me looking up the actual method
implementation when reading through this that this finished both, column and
offsets).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
