emkornfield commented on code in PR #34054:
URL: https://github.com/apache/arrow/pull/34054#discussion_r1157977911
##########
cpp/src/parquet/column_writer.h:
##########
@@ -91,7 +93,9 @@ class PARQUET_EXPORT PageWriter {
bool buffered_row_group = false,
std::shared_ptr<Encryptor> header_encryptor = NULLPTR,
std::shared_ptr<Encryptor> data_encryptor = NULLPTR,
- bool page_write_checksum_enabled = false);
+ bool page_write_checksum_enabled = false,
+ ColumnIndexBuilder* column_index_builder = NULLPTR,
Review Comment:
for completeness we should clarify that the builders must outlive the the
writer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
