icexelloss commented on code in PR #34904:
URL: https://github.com/apache/arrow/pull/34904#discussion_r1158643343
##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -602,7 +621,7 @@ class GroupByNode : public ExecNode, public TracedNode {
for (const auto& segment_key_field_id : segment_key_field_ids) {
if (key_field_id_set.find(segment_key_field_id) !=
key_field_id_set.end()) {
return Status::Invalid("Group-by aggregation with field '",
-
input_schema->field(segment_key_field_id)->name(),
Review Comment:
Yeah I think `const shared_ptr<Schema>&` is better because then some of the
lines using input_schema can be unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
