ayushdg commented on code in PR #5785:
URL: https://github.com/apache/arrow-datafusion/pull/5785#discussion_r1158804738
##########
datafusion/sql/src/expr/identifier.rs:
##########
@@ -47,7 +46,8 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// interpret names with '.' as if they were
// compound identifiers, but this is not a compound
// identifier. (e.g. it is "foo.bar" not foo.bar)
- let normalize_ident = normalize_ident(id);
+ let normalize_ident =
Review Comment:
Do you have a preference for whether a new struct should be created to
normalize ident or if we could just add the `normalize` method as an
implementation for `SqlToRel`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
