ayushdg commented on code in PR #5785: URL: https://github.com/apache/arrow-datafusion/pull/5785#discussion_r1160296352
########## datafusion/sql/src/statement.rs: ########## Review Comment: In cases like this with helper methods that get called from `SqlToRel` impl methods is there a better approach than adding a normalizer argument to each of these methods? https://github.com/apache/arrow-datafusion/blob/c5e935a15f22d16d8ca244e68b128f7c5ff28375/datafusion/sql/src/statement.rs#L54-L65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
