heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1159243990
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
Yes it's redundant. I feel something strange for the behavior of propagating
nulls to other columns, so I put it here to show as example for users. But I
will remove `:index` column here.
May be off topic of this PR, is it useful to propagate nulls in slicer?
I prefer to same behavior of `table#filter(boolean_array)` or `slicer.select
{ |value| .. }`.
(Null is not selected.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
