kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160263239
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
FYI: The following change will work for it:
```diff
diff --git a/ruby/red-arrow/lib/arrow/table.rb
b/ruby/red-arrow/lib/arrow/table.rb
index a14bf90d1f..da79e94b18 100644
--- a/ruby/red-arrow/lib/arrow/table.rb
+++ b/ruby/red-arrow/lib/arrow/table.rb
@@ -316,8 +316,6 @@ module Arrow
end
end
- filter_options = Arrow::FilterOptions.new
- filter_options.null_selection_behavior = :emit_null
sliced_tables = []
slicers.each do |slicer|
slicer = slicer.evaluate if slicer.respond_to?(:evaluate)
@@ -339,7 +337,7 @@ module Arrow
to += n_rows if to < 0
sliced_tables << slice_by_range(from, to)
when ::Array, BooleanArray, ChunkedArray
- sliced_tables << filter(slicer, filter_options)
+ sliced_tables << filter(slicer)
else
message = "slicer must be Integer, Range, (from, to), " +
"Arrow::ChunkedArray of Arrow::BooleanArray, " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
