nevi-me commented on a change in pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#discussion_r532205236
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -544,11 +488,20 @@ fn get_levels(
| ArrowDataType::Time64(_)
| ArrowDataType::Duration(_)
| ArrowDataType::Interval(_) => {
- let def_levels =
- get_primitive_def_levels(&child_array,
&list_def_levels[..]);
- vec![Levels {
+ let def_levels = get_primitive_def_levels(
+ &child_array,
+ list_field,
+ &list_def_levels[..],
+ );
+ vec![LevelInfo {
definition: def_levels,
repetition: Some(list_rep_levels),
+ array_mask: vec![],
+ array_offsets: vec![],
+ definition_mask: vec![],
+ is_list: true,
+ is_nullable: list_field.is_nullable(),
+ max_definition: level + 1, // TODO: update
Review comment:
This is a symptom of me having worked on this on & off for about 3
months now. so some TODOs are quite old. I've cleaned up many, and those that
still remain are to help me with list support, which I'm doing next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
