disq commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1160113250
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -1082,11 +1130,15 @@ func prepareListOfListTable(dt arrow.DataType, size,
nullCount int, nullablePare
}
func (ps *ParquetIOTestSuite) TestSingleEmptyListsColumnReadWrite() {
+ mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
+ //defer mem.AssertSize(ps.T(), 0) // FIXME: known leak
Review Comment:
This is a whack-a-mole leak.
> checked_allocator.go:127: LEAK of 448 bytes FROM
github.com/apache/arrow/go/v12/parquet/pqarrow.(*listReader).BuildArray line 383
Releasing `offsetsBuffer` a second time (or `defer offsetsBuffer.Resize(0)`)
seems to fix it (reason unknown to me as of writing) but then other tests start
failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
