disq commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1160104500
##########
go/parquet/internal/encoding/types.go:
##########
@@ -339,6 +339,12 @@ func (b *BufferWriter) Finish() *memory.Buffer {
return buf
}
+// Release the underlying buffer and not allocate anything else. To re-use
this buffer, Reset() or Finish() should be called
+func (b *BufferWriter) Release() {
Review Comment:
This had to be added, otherwise there's no way of completely "releasing the
memory" without "allocating" a new buffer. (memory management related quotes
used ironically)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
