lidavidm commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1160668854


##########
format/FlightSql.proto:
##########
@@ -1842,6 +1842,94 @@ message ActionCancelQueryResult {
   CancelResult result = 1;
 }
 
+/*
+ * Request message for the "Close Session" action.
+ */
+message ActionCloseSessionRequest {

Review Comment:
   I don't think I quite follow this as an answer; my concern here is that 
implementing sessions seems to require a lot of magic application code to 
handle all the different code paths in the server, when it seems we should be 
providing a standard interface here that gets turned into whatever underlying 
combination of headers and RPC requests. For instance, how does the server get 
the session identifier _at all_ right now? You hard-code a function that looks 
for a session cookie and then falls back to looking for headers?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to