lidavidm commented on PR #572: URL: https://github.com/apache/arrow-adbc/pull/572#issuecomment-1500249294
> In the existing version after connect() is called a new client object is created, but all of them shared the same allocator. That was probably a bug, right? See some recent Java commits/issues that change up how allocators are handled (the current implementation had leaks): https://github.com/apache/arrow-adbc/commit/e69723a158276d973cf6b84127ea590844e1efb5, https://github.com/apache/arrow-adbc/issues/563, https://github.com/apache/arrow-adbc/pull/564 > username/password passed as parameters named adbc.username and adbc.password (to be added in AdbcDriver). Are there any plans to have some sort of connection string syntax like JDBC? Only URIs for now (C/Go have settled on "uri" as the standard parameter, Java needs to align with that too) > It's functionally similar to the go example, but I couldn't use authenticateBasicToken because I couldn't find a way to extract bearer value from CredenialCallOption. Maybe there's a simpler way to accomplish this??? I will have to dig later but possibly/probably upstream needs to be fixed first; I don't think any of that was implemented to really do anything other than support the JDBC driver specifically > I'd like to keep FlightClient creation logic contained in clientCache. Right now the main FlightClient is created independently and only Endpoint clients are obtained from cache. If changed, main client will always have to be obtained from cache before usage, otherwise it might have expired. It seems you could factor out a factory function that can be used to create a one-off main client as well as cached clients? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
