tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160797704
##########
dev/release/create-tarball.sh:
##########
@@ -117,14 +117,11 @@ echo
"---------------------------------------------------------"
# create <tarball> containing the files in git at $release_hash
# the files in the tarball are prefixed with {tag} (e.g. 4.0.1)
-# use --delete to filter out:
-# 1. `object_store` files
-# 2. Workspace `Cargo.toml` file (which refers to object_store)
+# use --delete to filter out `object_store` files
mkdir -p ${distdir}
(cd "${SOURCE_TOP_DIR}" && \
git archive ${release_hash} --prefix ${release}/ \
| $tar --delete ${release}/'object_store' \
- | $tar --delete ${release}/'Cargo.toml' \
Review Comment:
Following #3936 this causes issues, as it removes the workspace from which
the properties are derived
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
