tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160798817
##########
dev/release/verify-release-candidate.sh:
##########
@@ -105,26 +105,15 @@ test_source_distribution() {
# raises on any formatting errors
rustup component add rustfmt --toolchain stable
- (cd arrow && cargo fmt --check)
- (cd arrow-flight && cargo fmt --check)
- (cd parquet && cargo fmt --check)
- (cd parquet_derive && cargo fmt --check)
+ cargo fmt --all -- --check
# Clone testing repositories if not cloned already
git clone https://github.com/apache/arrow-testing.git arrow-testing-data
git clone https://github.com/apache/parquet-testing.git parquet-testing-data
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data
- (cd arrow && cargo build && cargo test)
- (cd arrow-flight && cargo build && cargo test)
- # To avoid https://github.com/apache/arrow-rs/issues/3410,
- # remove path reference from parquet:
- # object_store = { version = "0.5", path = "../object_store",
default-features = false, optional = true }
- # object_store = { version = "0.5", default-features = false, optional =
true }
- sed -i -e 's/\(^object_store.*\)\(path = ".*", \)/\1/g' parquet/Cargo.toml
- (cd parquet && cargo build && cargo test)
- (cd parquet_derive && cargo build && cargo test)
+ cargo test --all
Review Comment:
I do wonder if we should be passing more features to this, but this is
strictly better than it was before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
