yjshen commented on PR #5868: URL: https://github.com/apache/arrow-datafusion/pull/5868#issuecomment-1500537165
Thank you @alamb for the detailed review! I have made the following updates to the PR based on your feedback: 1. The optional filter has been moved from aggregate expressions into `AggregateExec`. 2. All related tests have been moved into `.slt`, additional tests were added as per your review comments and tested against PostgreSQL results. 3. Miscellaneous dialect configuration changes were made as per your comments. By the way, it would be great if `create_dialect_from_str` could be moved upstream. I believe that this PR is now ready for further review. Thank you again, @alamb! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
