alamb commented on code in PR #5868:
URL: https://github.com/apache/arrow-datafusion/pull/5868#discussion_r1162016185
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1833,6 +1841,28 @@ impl From<&SessionState> for TaskContext {
}
}
+fn create_dialect_from_str(dialect_name: &str) -> Result<Box<dyn Dialect>> {
Review Comment:
I have ported this code upstream here:
https://github.com/sqlparser-rs/sqlparser-rs/pull/848
```suggestion
// TODO: remove when https://github.com/sqlparser-rs/sqlparser-rs/pull/848
is released
fn create_dialect_from_str(dialect_name: &str) -> Result<Box<dyn Dialect>> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
