wgtmac commented on code in PR #34961:
URL: https://github.com/apache/arrow/pull/34961#discussion_r1161372186
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -916,14 +916,14 @@ std::shared_ptr<Array>
RandomArrayGenerator::ArrayOf(const Field& field, int64_t
case Type::type::STRUCT: {
ArrayVector child_arrays(field.type()->num_fields());
- std::vector<std::string> field_names;
+ FieldVector child_fields;
for (int i = 0; i < field.type()->num_fields(); i++) {
const auto& child_field = field.type()->field(i);
child_arrays[i] = ArrayOf(*child_field, length, alignment,
memory_pool);
- field_names.push_back(child_field->name());
+ child_fields.push_back(child_field);
}
return *StructArray::Make(
- child_arrays, field_names,
+ child_arrays, child_fields,
Review Comment:
Shouldn't the original overload get the data type from `child_arrays`? I saw
a comment of the current overload saying `This method does not check that field
types and child array types are consistent.` It seems that we need to fix the
original `Make` function as well.
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -793,7 +793,7 @@ std::shared_ptr<Array> RandomArrayGenerator::ArrayOf(const
Field& field, int64_t
values_length, alignment, memory_pool);
\
const auto offsets = OffsetsFromLengthsArray(lengths.get(),
force_empty_nulls, \
alignment, memory_pool);
\
- return *ARRAY_TYPE::FromArrays(*offsets, *values);
\
+ return *ARRAY_TYPE::FromArrays(field.type(), *offsets, *values);
\
Review Comment:
Does map type have similar issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
